Remove version requirement for YARP package

[Nicogene]

This is for the migration to YARP4.

see:

• Migration to YARP4 robotology/robotology-superbuild#1945

[gemini-code-assist]

Summary of Changes

Hello @Nicogene, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project's build configuration by removing a specific version constraint for the YARP package. This change is crucial for facilitating the migration to YARP4, allowing the build system to link against newer versions of YARP and ensuring broader compatibility for future development.

Highlights

• YARP Version Requirement: The explicit version requirement 3.12.0 for the YARP package has been removed from the find_package call in CMakeLists.txt.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the explicit version requirement for the YARP package in the main CMakeLists.txt file, to facilitate the migration to YARP4. While this change allows using newer YARP versions, completely removing the version constraint is not recommended. It can lead to obscure build failures if an older, incompatible version of YARP is present on a developer's system. My review includes a suggestion to re-introduce a minimum version requirement, such as 4.0, to ensure build-time dependency checking and improve the developer experience.

[gemini-code-assist]

Removing the version requirement for YARP completely can lead to issues. If this project is built against an older, incompatible version of YARP, it might result in cryptic compilation errors instead of a clear message from CMake about the version mismatch. To improve maintainability and provide clearer build-time errors, it's best practice to specify a minimum required version.

Given that this change is for migrating to YARP4, I suggest specifying 4.0 as the minimum version. If the code is still compatible with older versions, please specify the oldest supported version.

find_package(YARP 4.0 COMPONENTS conf os sig dev math idl_tools REQUIRED)