AB#4040: Drop unused SeeAlsoLink + CommandDocumentation.SeeAlso #156
Merged
Conversation
Single workspace usage was removed under AB#4079; plumbing was over-engineered for N=1. Breaking change to public CommandLineParser API — verified zero in-workspace consumers across 5 pinned consumer repos. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes dead “SeeAlso” documentation infrastructure from Meshmakers.Common.CommandLineParser after upstream consumers were eliminated, simplifying the public API surface.
Changes:
- Deleted the unused
SeeAlsoLinktype. - Removed the
SeeAlsoparameter from theCommandDocumentationrecord.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/CommandLineParser/SeeAlsoLink.cs |
Removes the unused related-doc link model type. |
src/CommandLineParser/CommandDocumentation.cs |
Simplifies CommandDocumentation by dropping the unused SeeAlso field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
reikla
approved these changes
Jun 2, 2026
mmjakubpoddebniak
deleted the
dev/int64/octo-cli-auto-documentation-generator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SeeAlsoplumbing inCommandLineParserwas over-engineered for N=1: the field had a single workspace usage (AddOctoTenantIdentityProvider→ Cross-Tenant Authentication), removed under AB#4079. This PR drops the dead infrastructure.Verified zero in-workspace consumers across all 5 pinned consumer repos (
octo-cli,octo-common-services,octo-construction-kit-engine,octo-construction-kit-engine-mongodb,octo-distributedEventHub).What changed
src/CommandLineParser/SeeAlsoLink.cs.SeeAlsoparameter from theCommandDocumentationrecord.