Skip to content

RadioLibInterface: drop "caught missed RX_DONE" from WARN to DEBUG #10255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightjoker7 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

RadioLibInterface: drop "caught missed RX_DONE" from WARN to DEBUG #10255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/mesh/RadioLibInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,12 @@ void RadioLibInterface::resetAGC()
void RadioLibInterface::checkRxDoneIrqFlag()
{
if (iface->checkIrq(RADIOLIB_IRQ_RX_DONE)) {
LOG_WARN("caught missed RX_DONE");
// This is the normal recovery path for back-to-back RX events where the
// second packet's DIO1 edge happens while the GPIO interrupt was still
Copy link
Copy Markdown
Contributor

@thebentern thebentern Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the log level changes, but this comment block is a novel 😓

// disabled (between ISR disable and the handler re-enabling it).
// Matches the log level used for other "compensated for a normal radio
// oddity" events in this file (e.g. "Ignore false preamble detection").
LOG_DEBUG("Caught RX_DONE via poll (ISR-missed edge, normal under dense RX)");
notify(ISR_RX, true);
}
}
Expand Down
Loading