Skip to content

Bugfix/90 fix app install#91

Merged
mesilov merged 8 commits intodevfrom
bugfix/90-fix-app-install
Mar 14, 2026
Merged

Bugfix/90 fix app install#91
mesilov merged 8 commits intodevfrom
bugfix/90-fix-app-install

Conversation

@mesilov
Copy link
Owner

@mesilov mesilov commented Mar 14, 2026

Q A
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #90
License MIT

mesilov added 2 commits March 14, 2026 13:46
… for project-level server settings, update `.gitignore`, and enhance project docs with MCP usage instructions.

Signed-off-by: mesilov <mesilov.maxim@gmail.com>
… setup steps for `gh` CLI, GitHub MCP, and MCP servers; synchronize `README.md`, `AGENTS.md`, and `docs/tech-stack.md`; introduce environment readiness checklist.

Signed-off-by: mesilov <mesilov.maxim@gmail.com>
@mesilov mesilov marked this pull request as draft March 14, 2026 08:22
@mesilov mesilov self-assigned this Mar 14, 2026
@mesilov mesilov added the bug Something isn't working label Mar 14, 2026
@mesilov mesilov added this to the 0.5.0 milestone Mar 14, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on resolving a bug affecting the initial state of Bitrix24 application installations and significantly enhancing the developer onboarding experience. It introduces structured documentation updates to guide developers and agents through setting up their environment, particularly concerning MCP servers and command-line tools. The changes aim to streamline development workflows and ensure consistent environment configurations across the team.

Highlights

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
Activity
  • No specific review comments or activity have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses issue #90 by fixing an application installation issue and significantly improving the developer setup documentation. It introduces a .mcp.json configuration file and updates several markdown files (README.md, CLAUDE.md, AGENTS.md) to guide developers on using MCP servers. The .gitignore and CHANGELOG.md files are also updated accordingly. The changes are well-structured. I've left a couple of minor suggestions to improve file formatting and adhere to common conventions.

Comment on lines +1 to +8
{
"mcpServers": {
"bitrix24-dev": {
"type": "http",
"url": "https://mcp-dev.bitrix24.tech/mcp"
}
}
} No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's a good practice for files to end with a newline character. This can prevent issues with some command-line tools and file processing scripts. I've added one to the file.

Suggested change
{
"mcpServers": {
"bitrix24-dev": {
"type": "http",
"url": "https://mcp-dev.bitrix24.tech/mcp"
}
}
}
{
"mcpServers": {
"bitrix24-dev": {
"type": "http",
"url": "https://mcp-dev.bitrix24.tech/mcp"
}
}
}

Comment on lines +5 to +7



Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are several extra blank lines here. To improve readability, it's best to remove them. Usually, one blank line is enough to separate content blocks.

mesilov added 6 commits March 15, 2026 01:31
…p and two-step application installation flows: adjust status transitions, consolidate finish-step handling, and update developer documentation with user stories, sequence diagrams, and invariants.

Signed-off-by: mesilov <mesilov.maxim@gmail.com>
… transitions, implement distinct flows for single-step and two-step installations, update developer documentation with new user stories, clear finish-flow steps, sequence diagrams, and corner case handling.

Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…dling for pending installations, implement SDK-compatible `reinstall` flow, update functional and unit tests, and align developer documentation with new contracts and finish-flows.

Signed-off-by: mesilov <mesilov.maxim@gmail.com>
… handling for pending installations, establish strict finish-flow sequencing, implement controlled exception paths, update duplicate/mismatch handling, fix `reinstall` flows, revise tests, and update documentation with new canonical flows and sequence diagrams.

Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…installation handling, canonicalize finish-step flows, add `reinstall` and corner-case logic, improve tests, and extend documentation with detailed user stories and sequence diagrams.

Signed-off-by: mesilov <mesilov.maxim@gmail.com>
…: introduce in-memory repositories, collecting logger, and spy flusher; replace mocks with real implementations; update unit test logic, assertions, and coverage; standardize handling of pending installations and application tokens.

Signed-off-by: mesilov <mesilov.maxim@gmail.com>
@mesilov mesilov marked this pull request as ready for review March 14, 2026 21:06
@mesilov mesilov merged commit b36baf1 into dev Mar 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

1 participant