fix: make layer compositor UTF-8 aware#127
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #124
The compositor treated layer content as bytes, one grid cell per byte. Multibyte characters like the rounded border glyphs got split across three cells, and with a color active each fragment was wrapped in its own escape codes, so terminals showed replacement chars and the borders came out three times too wide.
Cells now hold the full UTF-8 sequence of a character and painting advances by display width, so wide chars cover two columns. Added tests for plain and styled multibyte content, overlay alignment and wide chars.