Skip to content

Fix NCU CSV NaN parser crash on empty unit cells #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiannanWang wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

Fix NCU CSV NaN parser crash on empty unit cells #134

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion kernel_perf_agent/kernel_opt/profiler/ncu_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,10 @@ def load_ncu_metrics(

# Drop the units row (first row often contains units like "%", "inst", etc.)
if len(sub) > 0:
first_row_str = sub.iloc[0].astype(str).str.lower()
# ``.str.lower()`` propagates NaN/pd.NA cells back to float NaN, which
# would crash the ``tok in x`` substring check below. ``fillna("")``
# makes the detection NaN-safe without changing the matching logic.
first_row_str = sub.iloc[0].astype(str).str.lower().fillna("")
unit_tokens = ("%", "inst", "cycle", "block", "register", "register/thread")
if first_row_str.apply(lambda x: any(tok in x for tok in unit_tokens)).any():
sub = sub.iloc[1:].reset_index(drop=True)
Expand Down
Loading