Replace Cases with enum Tag and switch statements#99
Open
Apanatshka wants to merge 6 commits intomasterfrom
Open
Replace Cases with enum Tag and switch statements#99Apanatshka wants to merge 6 commits intomasterfrom
Apanatshka wants to merge 6 commits intomasterfrom
Conversation
Contributor
Author
|
Welp, the tests fail, so I probably made a mistake in refactoring one of these things. I'll ping when this passes the tests. |
Contributor
Author
|
Cool, the tests run now. |
Contributor
Author
|
@AZWN we can look at this together tomorrow if you like |
Contributor
|
Looks good, and sounds like a plan! Tomorrow after lunch? |
Contributor
Author
|
Works for me. If you can find the time, please run a benchmark / profiling example beforehand so we can evaluate the performance implications as well as the code changes. |
Contributor
Author
|
So the good news is I was able to fairly easily change to using switch for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a look at the
Casespattern in thestatix.solverproject and tried replacing it with switch statements. This seems to work out alright, doesn't gives much more ugly code (some cases I'd argue the code even gets better), and should be somewhat faster I think. Can you try running your benchmark/profiling example on this version and see if it makes a difference in performance? This doesn't get rid of all the lambdas, but it should help I think/hope.