Skip to content

validating-deployments-existence-before-going-in-watch-mode#150

Closed
diaabadr wants to merge 3 commits intometacall:masterfrom
diaabadr:inspect-validating-deployments
Closed

validating-deployments-existence-before-going-in-watch-mode#150
diaabadr wants to merge 3 commits intometacall:masterfrom
diaabadr:inspect-validating-deployments

Conversation

@diaabadr
Copy link
Contributor

@diaabadr diaabadr commented Apr 3, 2023

No description provided.

@diaabadr
Copy link
Contributor Author

diaabadr commented Apr 4, 2023

@Creatoon I have included a new test to evaluate the new validation. It validates the 3 formats.

@viferga
Copy link
Member

viferga commented Apr 26, 2023

Oh shit I did not notice and I have implemented this today XD

I just wanted to inspect through OpenAPIv3 and there was no error info, that's why I added it, then I pushed the changes and I noticed just now that this PR is open.

@viferga
Copy link
Member

viferga commented Apr 26, 2023

By the way, the part of ensureDeploymentsExist is still highly useful, can you update this PR with last changes done by me and add this check to inspect?

I change it to draft meanwhile.

@viferga viferga marked this pull request as draft April 26, 2023 15:30
@diaabadr diaabadr closed this Apr 27, 2023
@diaabadr
Copy link
Contributor Author

@viferga
Absolutely, I will update it asap.

@diaabadr diaabadr reopened this Apr 27, 2023
@diaabadr diaabadr closed this by deleting the head repository Apr 27, 2023
@diaabadr
Copy link
Contributor Author

@viferga Done. i opened a new pr for it #152 because i got some errors while pushing to the last one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants