Draft
Conversation
viferga
reviewed
Jul 22, 2024
Member
There was a problem hiding this comment.
This should not be commited, the version is not 1.
viferga
reviewed
Jul 22, 2024
Member
There was a problem hiding this comment.
The definition of the interfaces is correct, but the interface API should not be modified, this will imply we have to modify metacall-deploy too, and maybe other dependencies. I do not want to do that yet.
Member
|
@HeeManSu I have added few comments, review them and I will merge the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.