Remove self-assignments in for-loops from older go versions.

cmd/common_test.go

@@ -82,7 +82,6 @@ func (c *test[R]) testCmd(t *testing.T) {
 	}
 
 	for _, format := range outputFormats(c) {
-		format := format
 		t.Run(fmt.Sprintf("%v", format.Args()), func(t *testing.T) {
 			_, out, config := c.newMockConfig(t)
 

cmd/completion/machine.go

@@ -94,8 +94,6 @@ func (c *Completion) IssueTypeCompletion(cmd *cobra.Command, args []string, toCo
 	}
 	var names []string
 	for _, issue := range resp.Payload {
-		issue := issue
-
 		if issue.ID == nil {
 			continue
 		}
@@ -119,8 +117,6 @@ func (c *Completion) IssueSeverityCompletion(cmd *cobra.Command, args []string,
 
 	severities := map[string]bool{}
 	for _, issue := range resp.Payload {
-		issue := issue
-
 		if issue.Severity == nil {
 			continue
 		}

cmd/machine.go

@@ -90,7 +90,6 @@ func (c *machineCmd) listCmdFlags(cmd *cobra.Command, lastEventErrorThresholdDef
 	cmd.Flags().String("network-ips", "", "network ips to filter [optional]")
 
 	for _, c := range listFlagCompletions {
-		c := c
 		genericcli.Must(cmd.RegisterFlagCompletionFunc(c.flagName, c.f))
 	}
 

cmd/partition.go

@@ -176,7 +176,6 @@ func (c *partitionCmd) partitionCapacity() error {
 	}
 
 	for _, pc := range resp.Payload {
-		pc := pc
 		sort.SliceStable(pc.Servers, func(i, j int) bool {
 			return pointer.SafeDeref(pointer.SafeDeref(pc.Servers[i]).Size) < pointer.SafeDeref(pointer.SafeDeref(pc.Servers[j]).Size)
 		})

cmd/switch.go

@@ -334,8 +334,6 @@ func (c *switchCmd) switchMachines() error {
 
 	ms := map[string]*models.V1MachineIPMIResponse{}
 	for _, m := range machines {
-		m := m
-
 		if m.ID == nil {
 			continue
 		}

cmd/tableprinters/machine.go

@@ -311,8 +311,6 @@ func (t *TablePrinter) MachineIssuesTable(data *MachinesAndIssues, wide bool) ([
 
 	machinesByID := map[string]*models.V1MachineIPMIResponse{}
 	for _, m := range data.Machines {
-		m := m
-
 		if m.ID == nil {
 			continue
 		}
@@ -322,8 +320,6 @@ func (t *TablePrinter) MachineIssuesTable(data *MachinesAndIssues, wide bool) ([
 
 	issuesByID := map[string]*models.V1MachineIssue{}
 	for _, issue := range data.Issues {
-		issue := issue
-
 		if issue.ID == nil {
 			continue
 		}

cmd/tableprinters/partition.go

@@ -58,8 +58,6 @@ func (t *TablePrinter) PartitionCapacityTable(data []*models.V1PartitionCapacity
 	}
 
 	for _, pc := range data {
-		pc := pc
-
 		for _, c := range pc.Servers {
 			id := pointer.SafeDeref(c.Size)
 

cmd/tableprinters/size.go

@@ -65,8 +65,6 @@ func (t *TablePrinter) SizeReservationTable(data []*models.V1SizeReservationResp
 	}
 
 	for _, d := range data {
-		d := d
-
 		desc := d.Description
 		if !wide {
 			desc = genericcli.TruncateEnd(d.Description, 50)
@@ -104,8 +102,6 @@ func (t *TablePrinter) SizeReservationUsageTable(data []*models.V1SizeReservatio
 	}
 
 	for _, d := range data {
-		d := d
-
 		row := []string{
 			pointer.SafeDeref(d.ID),
 			pointer.SafeDeref(d.Sizeid),

cmd/tableprinters/switch.go

@@ -165,8 +165,6 @@ func (t *TablePrinter) SwitchWithConnectedMachinesTable(data *SwitchesWithMachin
 			filteredConns := []*models.V1SwitchConnection{}
 
 			for _, conn := range s.Connections {
-				conn := conn
-
 				m, ok := data.MS[conn.MachineID]
 				if !ok {
 					continue
@@ -298,7 +296,6 @@ func (t *TablePrinter) SwitchDetailTable(data []*SwitchDetail, wide bool) ([]str
 	)
 
 	for _, sw := range data {
-		sw := sw
 		filterBySwp := map[string]models.V1BGPFilter{}
 		for _, n := range sw.Nics {
 			swp := *(n.Name)