feat: Add configurable server IP for DHCP responses#32
Closed
robertvolkmann wants to merge 6 commits intomainfrom
Closed
feat: Add configurable server IP for DHCP responses#32robertvolkmann wants to merge 6 commits intomainfrom
robertvolkmann wants to merge 6 commits intomainfrom
Conversation
Add the ability to configure a fixed source IP address for DHCP and PXE responses through a new --server-ip flag. This is particularly useful when network interfaces don't have IPv4 addresses configured but DHCP/PXE services still need to operate with a specific source IP. Changes include: - Add new ServerIP configuration option to Server struct - Implement --server-ip CLI flag with IPv4 validation - Modify DHCP and PXE services to use configured IP when available - Maintain backward compatibility by keeping auto-detection as default - Allow DHCP/PXE operation even when interfaces lack IPv4 addresses Example: pixiecore --server-ip 192.168.1.10 [other options]
Contributor
|
Can you describe the scenario in which the network interfaces do not have IPv4 addresses configured? Where does the pixiecore run? |
Before:
dhcp":{"mac":"fMJV5Tr9","error":"packet is DHCPREQUEST, not DHCPDISCOVER"}
Contributor
Author
|
Some dual-attached server with unnumbered interfaces, nothing special. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to configure a fixed source IP address for DHCP and PXE responses through a new --server-ip flag. This is particularly useful when network interfaces don't have IPv4 addresses configured but DHCP/PXE services still need to operate with a specific source IP.
Changes include:
--server-ipCLI flag with IPv4 validationExample:
pixiecore --server-ip 192.168.1.10 [other options]