Skip to content

Tweaking asset signer methodology#86

Merged
MarkSackerberg merged 1 commit intofeat/core-executefrom
feat/core-execute-keith
Mar 19, 2026
Merged

Tweaking asset signer methodology#86
MarkSackerberg merged 1 commit intofeat/core-executefrom
feat/core-execute-keith

Conversation

@blockiosaurus
Copy link
Contributor

Instead of using the authority as the identity, setting the asset signer as the identity via a NoopSigner. This allows it to be defaulted without needing to use getEffectiveSigner or do any transaction rewriting. Both the payer and identity can be the asset signer.

The one caveat is that we do need to manually override the feePayer on the transaction in the send instruction. This is due to how we handle the payer, where we conflate the instruction payer (rent on accounts) with the transaction payer. We want the asset signer to be the one paying rent and fees, we only want the authority signer to be paying transaction fees. So we need this override.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 19, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2c461803-0c68-45b8-b9eb-2dfa0cb200bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/core-execute-keith
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@MarkSackerberg MarkSackerberg merged commit b2a7314 into feat/core-execute Mar 19, 2026
4 checks passed
@MarkSackerberg MarkSackerberg deleted the feat/core-execute-keith branch March 19, 2026 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants