Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Summary by CodeRabbit
WalkthroughAdded two CLI navigation links and comprehensive multilingual documentation for MPL Core Asset-Signer Wallets and the Changes
Sequence Diagram(s)sequenceDiagram
participant User as User (developer)
participant CLI as Metaplex CLI
participant Config as CLI Config
participant RPC as Solana RPC
participant MPL as MPL Core Program
User->>CLI: run command (e.g., mint / transfer / core asset execute info)
CLI->>Config: check active wallet
alt Active wallet is asset-signer (PDA)
CLI->>CLI: wrap original instructions into `execute` instruction
CLI->>RPC: submit transaction (signed by asset owner via PDA mechanism, fee payer optional)
RPC->>MPL: deliver `execute` instruction
MPL->>MPL: validate asset existence + PDA signer
MPL-->>RPC: return on-chain result
RPC-->>CLI: relay result
CLI-->>User: show output (plain or JSON)
else No asset-signer active
CLI->>RPC: submit original transaction
RPC->>Chain: process normally
RPC-->>CLI: relay result
CLI-->>User: show output
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 9
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/pages/en/dev-tools/cli/config/asset-signer-wallets.md`:
- Line 232: The file ends without a trailing newline; add a single newline
character at EOF so the final line ("Raw instructions via `mplx toolbox raw` are
wrapped in `execute()` like any other command when an asset-signer wallet is
active") is followed by one newline to satisfy markdownlint; update the file
src/pages/en/dev-tools/cli/config/asset-signer-wallets.md accordingly.
In `@src/pages/ja/dev-tools/cli/core/execute.md`:
- Around line 31-55: This file's H2 headings (e.g., "基本的な使い方", "引数", "グローバルフラグ")
currently start with code or tables instead of a BLUF sentence; insert a single
direct declarative BLUF sentence immediately below each H2 (and any H3) and
before the following code block or table (for example: under "基本的な使い方" add a
one-line summary like "基本的な使用方法と例を示します。", under "引数" add
"コマンドが受け取る引数の一覧と意味を示します。", and under "グローバルフラグ" add "コマンドで使用できる共通フラグを説明します。") to
satisfy the guideline that the first sentence under every H2/H3 must be a direct
declarative BLUF.
In `@src/pages/ko/dev-tools/cli/config/asset-signer-wallets.md`:
- Line 30: The frontmatter answer value for the `a:` key in
asset-signer-wallets.md is wrapped in accidental surrounding quotes; remove the
extra leading and trailing quote characters so the `a:` value is a plain YAML
string (e.g., change `a: "`...`"` to `a: ...`) ensuring the FAQ frontmatter
parses and renders consistently; locate the `a:` frontmatter entry in the file
and strip the enclosing quotes while preserving the Korean text and any internal
punctuation.
- Around line 44-67: Add a one-sentence BLUF directly under the "## 빠른 시작"
heading that states the quick outcome (e.g., "Set up an asset-signer wallet and
switch to the PDA signer in six steps."), then add jump links (anchor links)
above the code block that map to each major step in the example sequence (e.g.,
"Create asset", "Register wallet", "Check PDA", "Fund PDA", "Set signer", "Use
PDA"). Ensure the anchors correspond to the step labels used in the code block
(referencing the code block title "Asset-signer wallet setup" and the commands
in the example) so users can click to jump to the relevant step.
In `@src/pages/ko/dev-tools/cli/config/wallets.md`:
- Line 10: Update the inline link target so the callout points to the Korean
docs locale: replace the path segment
'(/dev-tools/cli/config/asset-signer-wallets)' in the markdown line containing
"MPL Core 에셋의 PDA를 지갑으로" with '(/ko/dev-tools/cli/config/asset-signer-wallets)'
so the link stays within the /ko locale.
In `@src/pages/zh/dev-tools/cli/config/asset-signer-wallets.md`:
- Around line 37-38: Update the internal links in the Markdown content to use
Chinese-localized routes: replace occurrences of "/core" with "/zh/core" and any
"/dev-tools/..." or other site-internal paths (for example
"/dev-tools/cli/core/execute") with their "/zh/..." equivalents so all in-file
links point to the Chinese locale; verify and update the other mentioned
occurrences (the links around the second block and the sections noted) to their
corresponding "/zh/..." routes to ensure consistent locale behavior.
- Around line 44-67: The Quick Start section heading "## 快速开始" currently jumps
straight into a code block without the required BLUF sentence and jump links;
add a one-sentence BLUF directly under the "## 快速开始" heading that states what
the reader will achieve (e.g., "快速引导：在本节中您将创建资产并将其注册为资产签名者钱包，以便使用PDA进行转账和创建NFT。"
or equivalent), and insert a short set of jump links (anchor-style bullets)
before the code block linking to the main steps shown in the example (e.g.,
"创建资产", "注册为钱包", "查看PDA信息", "为PDA注资", "切换钱包", "以PDA身份使用命令") so readers can
navigate directly to each step; ensure the text uses the exact heading label "##
快速开始" and place the BLUF as the first sentence under that heading and the jump
links immediately after the BLUF and before the fenced code block.
In `@src/pages/zh/dev-tools/cli/config/wallets.md`:
- Line 10: Update the internal link in the wallets.md text from
"/dev-tools/cli/config/asset-signer-wallets" to the Chinese-localized path
"/zh/dev-tools/cli/config/asset-signer-wallets" so the callout uses the same
locale prefix as the rest of the file; locate the string in the sentence
containing "MPL Core资产的PDA用作钱包" and replace the link target accordingly.
In `@src/pages/zh/dev-tools/cli/core/execute.md`:
- Around line 31-55: 在每个 H2 标题（“## 基本用法”、“## 参数”、“## 全局标志”）下方插入一条简短的
BLUF（直接结论）句子，放在任何代码块或表格之前；例如在“## 基本用法”写一行类似“展示如何获取指定资产的 execute 信息。”，在“##
参数”写一行概述参数用途（如“列出命令接受的参数及其含义。”），在“##
全局标志”写一行概述可用全局标志（如“描述可用于所有命令的全局标志及其默认值。”），确保每个句子为直接声明句并位于相应标题下的首行。
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 9b3ce049-a2ce-4820-a516-1d4eba0cba34
📒 Files selected for processing (13)
src/components/products/cli/index.jssrc/pages/en/dev-tools/cli/config/asset-signer-wallets.mdsrc/pages/en/dev-tools/cli/config/wallets.mdsrc/pages/en/dev-tools/cli/core/execute.mdsrc/pages/ja/dev-tools/cli/config/asset-signer-wallets.mdsrc/pages/ja/dev-tools/cli/config/wallets.mdsrc/pages/ja/dev-tools/cli/core/execute.mdsrc/pages/ko/dev-tools/cli/config/asset-signer-wallets.mdsrc/pages/ko/dev-tools/cli/config/wallets.mdsrc/pages/ko/dev-tools/cli/core/execute.mdsrc/pages/zh/dev-tools/cli/config/asset-signer-wallets.mdsrc/pages/zh/dev-tools/cli/config/wallets.mdsrc/pages/zh/dev-tools/cli/core/execute.md
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/pages/en/dev-tools/cli/config/asset-signer-wallets.md`:
- Around line 44-46: Add a single direct BLUF (one declarative sentence)
immediately under each H2/H3 heading that currently jumps straight into a code
block/table/list (for example under "Quick Start" before the ```bash {%
title="Asset-signer wallet setup" %} block) and similarly for the other headings
noted in the comment; locate each heading that is immediately followed by a code
block or table and insert one clear bottom-line-up-front sentence that answers
the reader up front, then keep the existing code/table/list unchanged.
- Around line 103-123: The intro claim "All CLI commands work with asset-signer
wallets" is too absolute; change the heading/sentence to "Most CLI commands work
with asset-signer wallets" (or similar) and add an inline pointer to the "CPI
Limitations" section and its bullet list so readers immediately know exceptions
— reference the phrase "execute()" and ensure the text explicitly notes that
operations like large account creation (Merkle trees, candy machines) and native
SOL wrapping may fail under CPI/execute() constraints; update the sentence near
the table to link/point to the "CPI Limitations" section for details.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 48715c25-d5d1-4e9d-8b0b-3645389b2c45
📒 Files selected for processing (1)
src/pages/en/dev-tools/cli/config/asset-signer-wallets.md
Comment on lines
+44
to
+46
| ## Quick Start | ||
|
|
||
| ```bash {% title="Asset-signer wallet setup" %} |
Contributor
There was a problem hiding this comment.
Add BLUF lead sentences under H2/H3 headings before code/tables/lists.
Several sections start with a code block/table/list instead of a direct declarative first sentence (Lines 44, 79, 175, 184, 197, 206, 228). Please add one direct answer sentence immediately under each heading.
As per coding guidelines, “The first sentence under every H2/H3 heading must be a direct declarative answer (BLUF - Bottom Line Up Front)”.
✍️ Example pattern
## Quick Start
+ This Quick Start registers an MPL Core asset as an asset-signer wallet and verifies PDA execution flow.
+
```bash {% title="Asset-signer wallet setup" %}Also applies to: 77-80, 173-176, 182-185, 195-198, 204-206, 226-228
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/pages/en/dev-tools/cli/config/asset-signer-wallets.md` around lines 44 -
46, Add a single direct BLUF (one declarative sentence) immediately under each
H2/H3 heading that currently jumps straight into a code block/table/list (for
example under "Quick Start" before the ```bash {% title="Asset-signer wallet
setup" %} block) and similarly for the other headings noted in the comment;
locate each heading that is immediately followed by a code block or table and
insert one clear bottom-line-up-front sentence that answers the reader up front,
then keep the existing code/table/list unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.