Skip to content

Introduce OfflineTrack for use with OfflinePlaylist#93

Merged
semohr merged 2 commits into
mainfrom
offlinetrack
May 4, 2026
Merged

Introduce OfflineTrack for use with OfflinePlaylist#93
semohr merged 2 commits into
mainfrom
offlinetrack

Conversation

@semohr
Copy link
Copy Markdown
Contributor

@semohr semohr commented May 1, 2026

This pull request introduces the new OfflineTrack class to provide an in-memory representation of tracks, similar to the existing OfflinePlaylist. This allows us to preserve track information even after deletion from the remote service, and to keep the Playlist class hierarchy cleanly separated between in-memory and service-synced implementations.

@semohr semohr temporarily deployed to integration_tests May 1, 2026 15:17 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests May 1, 2026 15:17 — with GitHub Actions Inactive
@semohr semohr requested a review from pSpitzner May 1, 2026 15:17
@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@semohr semohr temporarily deployed to integration_tests May 1, 2026 15:28 — with GitHub Actions Inactive
@semohr semohr temporarily deployed to integration_tests May 1, 2026 15:28 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@pSpitzner pSpitzner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Im still wondering how this helps with our desired synced-playlists-history class (that serves as ground truth, where we keep track of two remote playlists, and have for each track on each side a time stemp when it was added/moved/deleted)

but thats a topic for a pen-and papter discussion.

@semohr
Copy link
Copy Markdown
Contributor Author

semohr commented May 4, 2026

Im still wondering how this helps with our desired synced-playlists-history class (that serves as ground truth, where we keep track of two remote playlists, and have for each track on each side a time stemp when it was added/moved/deleted)

I ran into issues with OfflinePlaylist not being truly decoupled from the services. I'm still experimenting with different syncing ideas, but introducing OfflineTrack has resolved several a few headaches for me 😆

@semohr semohr merged commit c8f7938 into main May 4, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants