Feature/ara dataset specs#200
Open
caglarkucuk wants to merge 5 commits intometno:mainfrom
Open
Conversation
tnipen
reviewed
Oct 21, 2025
| "celsius": ["C", "degC", "°C"], | ||
| "km/h": ["kmh"], | ||
| "kg/m^2": ["mm", "Kg/m^2", "Kg/m2", "kg/m2"], | ||
| "kg/m^2": ["mm", "Kg/m^2", "Kg/m2", "kg/m2", "mm/6h", "mm/3h", "mm/1h"], # verif package should be handling the temporal accum window |
Member
There was a problem hiding this comment.
Not sure I understand this comment. Can you elaborate?
Author
There was a problem hiding this comment.
Input file to verif package should correspond to the temporal accumulation window, but the comment is indeed confusing and unnecessary.
Will remove it
Member
|
Also, can you run
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended identical variable names and added CRS for ARA domain (Closes #133 )