Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional KGO for samos coefficient estimation using adjacent validity times.
estimate-samos-coefficients-from-table/kgo_coordinates_adjacent.nc
Coefficient differences: Original (left) vs. Adjacent VTs (right)
estimate-samos-coefficients-from-table/kgo_gam_cube_adjacent.nc
Coefficient differences: Original (left) vs. Adjacent VTs (right)
Additional KGO for SAMOS GAM training
The
kgo_coords.pklfile contains gams for the historic forecast and truths. For each of these there is a gam for the means and standard deviations. Below I have plotted the means of both to try and demonstrate that the new KGO looks reasonable.The first plot is of the existing
kgo_coords.pklfile as usually configured in the acceptance test.The second plot is the output for the same test that is returned simply by changing the forecast period to be 1-hour earlier (a different validity time).
Similarly here are the GAMS for a validity time 1-hour later.
The final plot shows the GAMS in the new KGO (
kgo_coords_adjacent.pkl) that is created by looking at the original forecast period and the adjacent times +- 1 hour, which we've looked at individually above. The scales look to be a combination of the various validity times considered. The overall form is smoother which is also pleasing.As is fairly obvious above the GAMS fitted to the historic forecasts and the truths are incredibly similar. I've checked the
statistics_data on the forecast and truth GAMs and they are incredibly similar (though not identical). I generated the same kind of plot after changing the diagnostic to wind speed which is also present in the acceptance test data tables. The plots still look very similar but the scale is very slightly different between the historic forecasts and truths. This suggests that for the temperature diagnostic (shown above) our forecasts and the truths are generally very close (as you might hope) and as a result the GAMs appear incredibly similar as well.