Conversation
Removed a legacy `inline-block` workaround for service text-line elements and kept a single `inline` display path. Why the workaround was added: - It was introduced to reduce Firefox issues with inline `offsetTop` measurements and baseline gap noise during line-splitting. Why we remove it now: - Firefox no longer shows the issue this workaround targeted. - The workaround caused a mismatch between measurement-time layout and final render layout. - In edge cases, text looked like it fit during calculation, but wrapped after grouping. - This was more visible with custom fonts and mixed inline content.
…ent line measurement Wrap every split line in `textGroup` to stabilize measurements: each line gets a block-level wrapper, while inline flow is preserved inside the group, keeping the original visual appearance.
…because FF cannot take offset from inline)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed a legacy
inline-blockworkaround for service text-line elements and kept a singleinlinedisplay path.Why the workaround was added:
offsetTopmeasurements and baseline gap noise during line-splitting.Why we remove it now:
Also, to stabilize measurements:
textGroup: each line gets a block-level wrapper, while inline flow is preserved inside the group, keeping the original visual appearance.