Compliance: verification improvements and task-tracker initialization by metyatech · Pull Request #3 · metyatech/robotframework-unity-editor

metyatech · 2026-03-06T03:05:05Z

Brings the repository into compliance with AGENTS.md and project standards: - Initialized task-tracker (.tasks.jsonl). - Updated .githooks/pre-commit to run the full verification suite (scripts/verify.ps1). - Filled missing email in CODE_OF_CONDUCT.md. - Added mocked unit tests for UnityEditorLibrary to improve coverage. - Regenerated AGENTS.md via compose-agentsmd.

…d tests

metyatech · 2026-03-06T03:05:28Z

Brings the repository into compliance with AGENTS.md and project standards: - Initialized task-tracker (.tasks.jsonl). - Updated .githooks/pre-commit to run the full verification suite (scripts/verify.ps1). - Filled missing email in CODE_OF_CONDUCT.md. - Added mocked unit tests for UnityEditorLibrary to improve coverage. - Regenerated AGENTS.md via compose-agentsmd.

metyatech · 2026-03-06T03:08:20Z

Agent runner idle completed.

Repo: metyatech/robotframework-unity-editor
Engine: gemini-flash
Notify: @metyatech

Summary:
(missing)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08a365bebd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-06T03:08:44Z

.githooks/pre-commit

-if command -v compose-agentsmd > /dev/null 2>&1; then
-  compose-agentsmd --compose || true
-  git add AGENTS.md || true
+#!/bin/sh


Normalize pre-commit shebang to LF line endings

The updated hook is committed with CRLF line endings, so on POSIX environments the shebang becomes #!/bin/sh\r and Git cannot execute the hook (cannot execute: required file not found). This blocks all commits for contributors running the repo from Linux/macOS (including WSL/containers), so the hook change effectively breaks the commit workflow outside Git for Windows.

Useful? React with 👍 / 👎.

Copilot

Pull request overview

This PR targets repository compliance with the project’s agent standards by initializing task tracking, tightening local verification via pre-commit, updating community health metadata, and adding mocked unit tests for the Unity editor library.

Changes:

Initialized task-tracker state (.tasks.jsonl) and updated AGENTS.md via regeneration.
Updated .githooks/pre-commit to run the full verification suite (scripts/verify.ps1) before composing/staging AGENTS.md.
Added mocked unit tests for UnityEditorLibrary and filled in the enforcement contact email in CODE_OF_CONDUCT.md.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`tests/test_library_mocked.py`	Adds mocked unit tests covering several `UnityEditorLibrary` behaviors.
`CODE_OF_CONDUCT.md`	Replaces placeholder enforcement contact with a real email address.
`AGENTS.md`	Regenerated agent rules and updated pre-commit guidance/standards text.
`.tasks.jsonl`	Initializes task-tracker entries marking this compliance work as done.
`.githooks/pre-commit`	Runs full verification via PowerShell script, then updates/stages `AGENTS.md`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-06T03:10:27Z

AGENTS.md

 Source: github:metyatech/agent-rules@HEAD/rules/global/autonomous-operations.md

-# Autonomous operations
+# Autonomous operations


This heading appears to start with a BOM/zero-width character before # (rendered as # Autonomous operations). That hidden character can break markdown rendering/anchors and causes noisy diffs; please remove it and ensure the file is saved as UTF-8 without BOM (or regenerate with compose-agentsmd using the correct encoding).

Suggested change

# Autonomous operations

# Autonomous operations

Copilot · 2026-03-06T03:10:27Z

AGENTS.md

+- `&&` is not supported in PowerShell (it is a bash/Unix operator); use `;` to chain commands in PowerShell scripts and prompts.
+- When writing PowerShell, always use `;` for sequential command chaining; never use `&&` or `||` as control-flow operators.


These lines state that &&/|| are not supported in PowerShell, but they are supported in PowerShell 7+ (pwsh), which this repo uses in CI. If the intent is Windows PowerShell 5.1 compatibility or a style ban, please reword accordingly (e.g., “Avoid &&/|| for PS5.1 compatibility; use ; / explicit conditionals”).

Suggested change

- `&&` is not supported in PowerShell (it is a bash/Unix operator); use `;` to chain commands in PowerShell scripts and prompts.

- When writing PowerShell, always use `;` for sequential command chaining; never use `&&` or `||` as control-flow operators.

- In Windows PowerShell 5.1, `&&` / `||` are not supported (they are bash/Unix-style operators); use `;` to chain commands in cross-version PowerShell scripts and prompts.

- For scripts that must run on both Windows PowerShell 5.1 and PowerShell 7+, avoid `&&` / `||` and instead use `;` plus explicit conditionals for control flow.

Copilot · 2026-03-06T03:10:28Z

.githooks/pre-commit

+powershell.exe -NoProfile -ExecutionPolicy Bypass -File scripts/verify.ps1 || exit 1
+


The hook hard-codes powershell.exe, but CI runs the verification script under pwsh. To avoid failures on environments where Windows PowerShell isn’t available (or to keep consistent behavior), consider invoking pwsh when available and falling back to powershell.exe otherwise.

Suggested change

powershell.exe -NoProfile -ExecutionPolicy Bypass -File scripts/verify.ps1 || exit 1

if command -v pwsh > /dev/null 2>&1; then

POWERSHELL_CMD="pwsh"

elif command -v powershell > /dev/null 2>&1; then

POWERSHELL_CMD="powershell"

elif command -v powershell.exe > /dev/null 2>&1; then

POWERSHELL_CMD="powershell.exe"

else

echo "Error: Neither 'pwsh' nor 'powershell'/'powershell.exe' found in PATH." >&2

exit 1

fi

"$POWERSHELL_CMD" -NoProfile -ExecutionPolicy Bypass -File scripts/verify.ps1 || exit 1

Copilot · 2026-03-06T03:10:28Z

tests/test_library_mocked.py

+    mock_window.child_window.side_effect = Exception("Not found")
+
+    with pytest.raises(RuntimeError, match="Unity element was not found"):
+        library_instance._find_element(title="Hierarchy", timeout_seconds=0.1)


This test uses timeout_seconds=0.1, but _find_element sleeps 0.2s per retry, so the test will always incur an unnecessary sleep. Consider using timeout_seconds=0 (or patching time.sleep) to keep the unit test fast and deterministic.

Suggested change

library_instance._find_element(title="Hierarchy", timeout_seconds=0.1)

library_instance._find_element(title="Hierarchy", timeout_seconds=0)

Copilot · 2026-03-06T03:10:28Z

.githooks/pre-commit

+#!/bin/sh
+
+# Run full verification suite
+powershell.exe -NoProfile -ExecutionPolicy Bypass -File scripts/verify.ps1 || exit 1


This pre-commit hook invokes powershell.exe with -ExecutionPolicy Bypass, which disables PowerShell's execution policy and can circumvent enterprise script restrictions, allowing unsigned or tampered scripts/verify.ps1 to run even where such scripts would normally be blocked. An attacker who can modify this repository or the scripts/verify.ps1 file could abuse this hook to bypass host security controls and execute arbitrary code on developers' machines. Remove the -ExecutionPolicy Bypass flag (or adopt a stricter policy with script signing) so that PowerShell's configured execution policy continues to provide its intended protection.

Suggested change

powershell.exe -NoProfile -ExecutionPolicy Bypass -File scripts/verify.ps1 || exit 1

powershell.exe -NoProfile -File scripts/verify.ps1 || exit 1

Compliance: initialize task-tracker, update pre-commit, and add mocke…

08a365b

…d tests

Copilot AI review requested due to automatic review settings March 6, 2026 03:05

Copilot started reviewing on behalf of metyatech March 6, 2026 03:05 View session

metyatech self-assigned this Mar 6, 2026

chatgpt-codex-connector bot reviewed Mar 6, 2026

View reviewed changes

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compliance: verification improvements and task-tracker initialization#3

Compliance: verification improvements and task-tracker initialization#3
metyatech wants to merge 1 commit intomainfrom
fix/compliance-and-verification-improvements

metyatech commented Mar 6, 2026

Uh oh!

metyatech commented Mar 6, 2026

Uh oh!

metyatech commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Mar 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		- `&&` is not supported in PowerShell (it is a bash/Unix operator); use `;` to chain commands in PowerShell scripts and prompts.
		- When writing PowerShell, always use `;` for sequential command chaining; never use `&&` or `\|\|` as control-flow operators.

		powershell.exe -NoProfile -ExecutionPolicy Bypass -File scripts/verify.ps1 \|\| exit 1

-powershell.exe -NoProfile -ExecutionPolicy Bypass -File scripts/verify.ps1 || exit 1
+if command -v pwsh > /dev/null 2>&1; then
+  POWERSHELL_CMD="pwsh"
+elif command -v powershell > /dev/null 2>&1; then
+  POWERSHELL_CMD="powershell"
+elif command -v powershell.exe > /dev/null 2>&1; then
+  POWERSHELL_CMD="powershell.exe"
+else
+  echo "Error: Neither 'pwsh' nor 'powershell'/'powershell.exe' found in PATH." >&2
+  exit 1
+fi
+"$POWERSHELL_CMD" -NoProfile -ExecutionPolicy Bypass -File scripts/verify.ps1 || exit 1

	library_instance._find_element(title="Hierarchy", timeout_seconds=0.1)
	library_instance._find_element(title="Hierarchy", timeout_seconds=0)

	powershell.exe -NoProfile -ExecutionPolicy Bypass -File scripts/verify.ps1 \|\| exit 1
	powershell.exe -NoProfile -File scripts/verify.ps1 \|\| exit 1

Conversation

metyatech commented Mar 6, 2026

Uh oh!

metyatech commented Mar 6, 2026

Uh oh!

metyatech commented Mar 6, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants