Skip to content

fix: avoid path claims for non-path inline code#83

Open
miloquinn wants to merge 2 commits into
mex-memory:mainfrom
miloquinn:fix-ignore-non-path-inline-code
Open

fix: avoid path claims for non-path inline code#83
miloquinn wants to merge 2 commits into
mex-memory:mainfrom
miloquinn:fix-ignore-non-path-inline-code

Conversation

@miloquinn

Copy link
Copy Markdown

Summary

Why

checkPaths currently treats many backtick-wrapped values as path claims when they contain / or a known extension. In project docs this creates noisy MISSING_PATH errors for Kubernetes/GitOps notes like 192.168.5.0/24, argocd.argoproj.io/sync-wave, sudo ls /var/lib/kubelet/plugins_registry/, or .yaml.

Those are inline code snippets, not files the scaffold depends on.

Testing

  • npm test -- test/claims.test.ts
  • npm test -- test/checkers.test.ts
  • npm run typecheck
  • git diff --check

miloquinn and others added 2 commits June 18, 2026 18:14
- Skip inline IP/CIDR values, file extensions, shell commands, and dotted annotation keys when extracting path claims
- Add regression coverage for Kubernetes/GitOps-style inline code snippets

@theDakshJaitly theDakshJaitly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the focused hardening here. The overall direction makes sense, especially after #80, since ROUTER.md can still contain inline values that look path-like but are not filesystem paths.

I found one false-negative risk before approving: DOTTED_KEY_WITH_SLASH also matches valid root hidden-directory paths like .github/CODEOWNERS and .github/workflows. Those are realistic scaffold references, and this change would stop extracting them as path claims, so checkPaths would no longer validate them.

Could you tighten that matcher so Kubernetes-style dotted annotation/config keys are skipped without excluding .github/... paths? A regression test for .github/CODEOWNERS or .github/workflows would cover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants