feat: ship both sl and simplelogin binaries to avoid name conflicts - #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
slbinary name conflicts with the steam locomotive homebrew formula and Sapling VCS. Users with either installed can't use our CLI without uninstalling the other.Solution
Ship both
sl(primary) andsimplelogin(alias) binaries. They are identical — same binary, two names.Changes
.goreleaser.yaml: Added second build (id: simplelogin) producingsimpleloginbinary from the same source. Homebrew formula installs both and tests both.Makefile:make buildnow copiesbin/sltobin/simplelogin.make installinstalls both.README.md: Added note explaining the dual naming and when to usesimplelogininstead ofsl.