Skip to content

Parse data#27

Merged
nbedanova merged 9 commits intomainfrom
Parse-data
Oct 30, 2025
Merged

Parse data#27
nbedanova merged 9 commits intomainfrom
Parse-data

Conversation

@nbedanova
Copy link
Contributor

Updating some plotting functions for Parse data and making them a bit more general to work with all the datasets in this repo.

Also added doublet filtering for Parse data.

@nbedanova nbedanova requested a review from Copilot October 24, 2025 22:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates plotting functions and data import capabilities to work with Parse dataset, adds doublet filtering for Parse data, and makes existing plotting functions more flexible to work with multiple datasets.

Key changes:

  • Added doublet detection dependency and filtering for Parse data
  • Enhanced plotting functions with configurable parameters (condition names, center_data, mean aggregation)
  • Made visualization functions more general with improved font sizing and formatting options

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
pyproject.toml Added doubletdetection package dependency
pf2rnaseq/imports.py Added Parse data import with doublet filtering, added pandas import, updated copy operations
pf2rnaseq/figures/commonFuncs/plotPaCMAP.py Updated PaCMAP visualization colors and legend positioning
pf2rnaseq/figures/commonFuncs/plotGeneral.py Enhanced gene expression plotting with configurable parameters and improved cell count calculations
pf2rnaseq/figures/commonFuncs/plotFactors.py Added component weight plotting, improved gene set scoring visualization, adjusted factor plot formatting
pf2rnaseq/factorization.py Added negative value handling in condition correction and fixed rank indexing in R2X calculation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nbedanova and others added 2 commits October 29, 2025 11:46
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@nbedanova nbedanova requested a review from aarmey October 29, 2025 18:48
@nbedanova
Copy link
Contributor Author

nbedanova commented Oct 29, 2025

@aarmey I fear this might have gotten too unruly to review. Let me know if you want me to split this up. It is a lot of smaller changes so was not sure best way to approach this.

Copy link
Member

@aarmey aarmey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable. For the csv file, I'd move it into a data subfolder and gzip compress it so that it doesn't show up as text.

@nbedanova nbedanova marked this pull request as ready for review October 30, 2025 17:02
@nbedanova nbedanova requested a review from aarmey October 30, 2025 17:03
@nbedanova nbedanova merged commit 518d725 into main Oct 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments