docs: position-encoding ADR + inline doc-sync mutation addendum#13
Merged
Conversation
Add ADR 0016 (negotiate UTF-8, default UTF-16) and record the two decisions that depend on it: - ADR 0003 addendum: built-in document-sync mutations run inline in the read-loop in receipt order, not spawned, so incremental didChange edits can't land out of order and corrupt the rope. - ADR 0004 note: positionEncoding is the one capability outside the static-const model — it's negotiated from InitializeParams. These specify the document-sync slice tracked in #12 (Documents store), #10 (encoding negotiation), and #9 (inline dispatch). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the design docs for the document-sync slice so the issues that reference them have their spec on the branch.
Position.characteris a nativeropey/&strbyte offset (zero transcoding on the hot path).didOpen/didChange/didClose/didSave) run inline in the read-loop in receipt order, not spawned, so incremental edits can't reorder and corrupt the rope. User-side reactions (diagnostics, reparse) still spawn.positionEncodingis the one capability outside the static-const model; it's negotiated fromInitializeParams.Specifies the slice tracked in #12 (Documents store), #10 (encoding negotiation), and #9 (inline dispatch).
🤖 Generated with Claude Code