fix: post-shutdown requests return InvalidRequest (-32600) (#11)#14
Merged
Conversation
LSP lifecycle requires that requests arriving after `shutdown` error with InvalidRequest. The request gate only checked `Uninitialized`, so a request between `shutdown` and `exit` fell through to the method match (initialize -> wrong reason, anything else -> MethodNotFound). Add a `ShuttingDown` branch to the request path returning InvalidRequest (-32600) for any request, mirroring the `Uninitialized` -> ServerNotInitialized gate. `exit` stays on the notification path and is unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #11.
LSP lifecycle requires that requests arriving after a
shutdownrequest error withInvalidRequest. The dispatcher's request gate only checked theUninitializedstate, so a request sent betweenshutdownandexitfell through to the method match —initializereturned the right code for the wrong reason, and anything else returnedMethodNotFound(-32601).Change
ShuttingDownbranch to the request path that returnsInvalidRequest(-32600) for any request, mirroring the existingUninitialized->ServerNotInitializedgate.exit(a notification) stays on the notification path and is unaffected.LspError::InvalidRequest(-32600) and theinvalid_requestconstructor.Test
request_after_shutdown_returns_invalid_request: drives initialize -> shutdown ->textDocument/hoverand asserts the hover response is -32600, then confirmsexitstill terminates the dispatcher with code 0.🤖 Generated with Claude Code