feat: position encoding negotiation (#10)#16
Merged
Conversation
- Change server_capabilities(&self) to server_capabilities(&self, &InitializeParams) - Negotiate UTF-8 preferred / UTF-16 fallback from client general.positionEncodings - Write the chosen encoding into the Documents store - Add integration tests covering default, UTF-8, UTF-16-only, unsupported, and preference-order behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10.
Builds on the Documents store introduced in #12 to negotiate the LSP position encoding during initialize.
server_capabilities(&self)toserver_capabilities(&self, &InitializeParams)so it can read the client's offered encodings.general.positionEncodingswith lspf's preference order[utf-8, utf-16], falling back to UTF-16.Documentsstore so existing conversion methods pick it up automatically.All tests pass and clippy is clean.