ci: run fmt, clippy, test, and coverage across the workspace#27
Merged
Conversation
After the Cargo workspace migration (#20), add --workspace to the clippy, test, and coverage invocations so every member crate is built, linted, tested, and measured for coverage — not just the package in the current directory. fmt already uses --all, which covers the workspace. Verified locally with RUSTFLAGS="-D warnings": - cargo clippy --workspace --all-targets --all-features -- -D warnings - cargo test --workspace --all-features --all-targets - cargo test --workspace --all-features --doc Closes #23 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
.github/workflows/ci.ymlso CI continues to build, lint, test, and report coverage now that the repository is a Cargo workspace (#20).Adds
--workspaceto the clippy, test, and coverage invocations so every member crate (lspf,lspf-hello) is covered, not just the package in the current directory.fmtalready uses--all, which spans the workspace.Acceptance Criteria
cargo fmt --allalready covers the workspace).cargo clippy --workspace --all-targets --all-features).cargo test --workspace --all-features --all-targetsand passes (plus--doc).cargo llvm-cov --workspace ...) and uploads the report.RUSTFLAGS: -D warningsbehavior kept.target/coverage/...) are explicit output dirs, unaffected by the workspace layout.Verification
Ran locally with
RUSTFLAGS="-D warnings":cargo clippy --workspace --all-targets --all-features -- -D warnings— cleancargo test --workspace --all-features --all-targets— all passcargo test --workspace --all-features --doc— passCloses #23
🤖 Generated with Claude Code