Incremental cooperative rebalancing#283
Open
a-a-f wants to merge 1 commit intomfontanini:masterfrom
a-a-f:experiment
Open
Incremental cooperative rebalancing#283a-a-f wants to merge 1 commit intomfontanini:masterfrom a-a-f:experiment
a-a-f wants to merge 1 commit intomfontanini:masterfrom
a-a-f:experiment
Conversation
mfontanini
reviewed
Sep 3, 2021
| } | ||
|
|
||
| void Consumer::incremental_assign(const TopicPartitionList& topic_partitions) { | ||
| if (topic_partitions.empty()) { |
Owner
There was a problem hiding this comment.
Is this right? The documentation says:
The application must pass the partition list passed to the callback (or a copy of it), even if the list is empty.
mfontanini
reviewed
Sep 3, 2021
Owner
mfontanini
left a comment
There was a problem hiding this comment.
Sorry, it took me quite a bit to reply!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
I created this (hopefully) small PR not to get it merged but to receive comments about my use case. I hope I don't write in the wrong place. I have an issue and I am exploring three hypotheses to explain it:
At my job, as part of a project, we are tasked with adding support for incremental cooperative rebalancing in cppkafka. I built cppkafka from this PR against librdkafka v1.6.1 (yes it's an old version but it's a constraint at my job). I performed the following 2 tests:
There is no such odd behavior when switching to the roundrobin rebalancing strategy.
My question is: am I doing anything wrong with cppkafka?
I hope I clearly and concisely stated the problem I have been encountering and am thankful for any help.
Note: in order to make cppkafka build, I had to copy a couple of librdkafka headers manually, namely rdtypes.h and rdkafka_error.h. Indeed the external header generated by librdkafka after performing
./configure && make && make installdoes not export enough information.