Fix the destruction order of handle & destroy_flags#319
Open
filimonov wants to merge 1 commit intomfontanini:masterfrom
Open
Fix the destruction order of handle & destroy_flags#319filimonov wants to merge 1 commit intomfontanini:masterfrom
filimonov wants to merge 1 commit intomfontanini:masterfrom
Conversation
…ndleBase The MemorySanitizer detected a use-of-uninitialized-value issue caused by the destruction order in KafkaHandleBase. Specifically, the deleter of the Kafka handle accessed destroy_flags_ after it had been destroyed because destroy_flags_ was declared after handle_. This commit reorders the member declarations so that destroy_flags_ is declared before handle_. The constructor's initializer list is also updated accordingly to match the new declaration order.
Contributor
Author
|
example report from the memory sanitizer: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MemorySanitizer detected a use-of-uninitialized-value issue caused by the destruction order in KafkaHandleBase. Specifically, the deleter of the Kafka handle accessed
destroy_flags_after it had been destroyed becausedestroy_flags_was declared afterhandle_.This commit reorders the member declarations so that
destroy_flags_is declared beforehandle_. The constructor's initializer list is also updated accordingly to match the new declaration order.