Skip to content

Don't attempt to delete non-existent note#12

Open
mc2contributor wants to merge 1 commit into
mgarrido:notefrom
mc2contributor:patch-1
Open

Don't attempt to delete non-existent note#12
mc2contributor wants to merge 1 commit into
mgarrido:notefrom
mc2contributor:patch-1

Conversation

@mc2contributor

Copy link
Copy Markdown

rm -f $note should only be attempted if the note exists.
Otherwise you'll get an error message:

rm: /path/to/todo/notes/: is a directory

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • If you've added code that should be tested, add tests!
  • Ensure the test suite passes.
  • Format your code with ShellCheck.
  • Include a human-readable description of what the pull request is trying to accomplish.
  • Steps for the reviewer(s) on how they can manually QA the changes.
  • Have a fixes #XX reference to the issue that this pull request fixes.

`rm -f $note` should only be attempted if the note exists.
Otherwise you'll get an error message:

    rm: /path/to/todo/notes/: is a directory
ondras12345 added a commit to ondras12345/dotfiles that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant