Feature flexible note names#6
Open
adaschma wants to merge 16 commits into
Open
Conversation
- run all tests with action '__test' - requires shunit2 to be in $PATH
This is the minimal case of the old testgetnotenamefromtext_bugXX unittest
as covered by the testgetnotenamefromtext_multipleext test
Pass testliteralstringingrepregex_specialcharsprefixedbybackslash
A failing test for a discovered corner case
A regression when TODO_NOTE_AUTOEXT is not-empty
Author
|
@mgarrido it has been a quarter of a year since I posted the merge request. Have you have a chance to look at it? Are there any changes you wish I make? Is there anything I can do to make it easier for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow more flexible note file names. They can now include more then one dot as well as add allow an extension to be added without it cluttering the todo.txt line (via $TODO_NOTE_AUTOEXT). This change includes some simple unit tests.
Hope you like it. If you have any questions don't hesitate to ask.