Skip to content

[codex] Add Simplified Chinese localization#130

Open
IPFR33LY wants to merge 1 commit into
mgoeppner:mainfrom
IPFR33LY:codex/issue-114-chinese-language
Open

[codex] Add Simplified Chinese localization#130
IPFR33LY wants to merge 1 commit into
mgoeppner:mainfrom
IPFR33LY:codex/issue-114-chinese-language

Conversation

@IPFR33LY

@IPFR33LY IPFR33LY commented May 2, 2026

Copy link
Copy Markdown

Closes #114.

Summary

Adds Simplified Chinese (zh-CN) UI localization for EVEMon.

Changelog

  • Added persisted UI language selection with English and Simplified Chinese options.
  • Applied selected culture at startup before runtime forms are created.
  • Added zh-CN satellite resource files for runtime EVEMon projects.
  • Moved common designer literals into .resx resources so translated UI strings can load correctly.
  • Added restart-required messaging when the selected UI language changes.

Validation

  • dotnet restore EVEMon.sln --source https://api.nuget.org/v3/index.json
  • dotnet build EVEMon.sln -c Debug --no-restore
  • Resource validation: no missing zh-CN keys and no lost {0} placeholders.

Notes

dotnet test EVEMon.sln -c Debug --no-build --no-restore still has one existing failure in Tests.EVEMon.Common.AsyncVoidMethodsTests.EnsureNoAsyncVoidMethods for pre-existing SSOWebServerHttpListener async-void methods.

Implements Simplified Chinese UI localization for EVEMon, including persisted language selection, startup culture application, localized WinForms resources, and extracted designer strings for runtime UI coverage.

References mgoeppner#114.
@IPFR33LY
IPFR33LY marked this pull request as ready for review May 2, 2026 02:38
@mgoeppner

Copy link
Copy Markdown
Owner

Hi! Thanks for your contribution!

Can you confirm how you translated this? Was it ai translated or are you a speaker? EVE chinese terminology is not always easily translated.

@mgoeppner mgoeppner left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!

I have had some Chinese speakers review this, and they are quite confused about some of what they believe are AI translated phrases.

If you wish to continue working on this PR, let me know, there are a number of code changes which are also necessary, and if so I will happily mark them for you. I can also sort some Chinese speaking players to help with the translation process.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: A Chinese version is needed

2 participants