[codex] Add Simplified Chinese localization#130
Open
IPFR33LY wants to merge 1 commit into
Open
Conversation
Implements Simplified Chinese UI localization for EVEMon, including persisted language selection, startup culture application, localized WinForms resources, and extracted designer strings for runtime UI coverage. References mgoeppner#114.
IPFR33LY
marked this pull request as ready for review
May 2, 2026 02:38
Owner
|
Hi! Thanks for your contribution! Can you confirm how you translated this? Was it ai translated or are you a speaker? EVE chinese terminology is not always easily translated. |
mgoeppner
requested changes
May 4, 2026
mgoeppner
left a comment
Owner
There was a problem hiding this comment.
Hi!
I have had some Chinese speakers review this, and they are quite confused about some of what they believe are AI translated phrases.
If you wish to continue working on this PR, let me know, there are a number of code changes which are also necessary, and if so I will happily mark them for you. I can also sort some Chinese speaking players to help with the translation process.
Cheers!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114.
Summary
Adds Simplified Chinese (
zh-CN) UI localization for EVEMon.Changelog
zh-CNsatellite resource files for runtime EVEMon projects..resxresources so translated UI strings can load correctly.Validation
dotnet restore EVEMon.sln --source https://api.nuget.org/v3/index.jsondotnet build EVEMon.sln -c Debug --no-restorezh-CNkeys and no lost{0}placeholders.Notes
dotnet test EVEMon.sln -c Debug --no-build --no-restorestill has one existing failure inTests.EVEMon.Common.AsyncVoidMethodsTests.EnsureNoAsyncVoidMethodsfor pre-existingSSOWebServerHttpListenerasync-void methods.