Optimize IconSearch for better performance on large codebases#4
Merged
mgreen-simplethread merged 1 commit intoJan 15, 2026
Conversation
- Add parallel file reading in batches of 50 using Promise.all - Implement early exit when all indexed icons are found - Remove unnecessary corpus join - tokenize files separately to reduce memory - Optimize idsForIcon() with pre-allocated array instead of spread/map Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mgreen-simplethread
approved these changes
Jan 15, 2026
Owner
mgreen-simplethread
left a comment
There was a problem hiding this comment.
Not much better performance except maybe in cases where the index size is small, but it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance Improvements
Test plan
bun run typecheckpassesbun run formatapplied🤖 Generated with Claude Code