Skip to content

Enforced strict error on malformed self-closing tag. #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
springcomp wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Enforced strict error on malformed self-closing tag. #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9811719
Enforced strict error on malformed self-closing tag.
springcomp Jun 16, 2025
b76f7ea
fix: revert unnecessary reformats
springcomp Jun 16, 2025
c240d68
fix: > should still be part of the tag.
springcomp Jun 16, 2025
4413f24
fix: return null behaves like return this.
springcomp Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions Core.Tests/Parser/ParsingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,21 @@ public void BadClosingTag ()
result.AssertDiagnosticCount (2);
}

[Test]
public void MalformedSelfClosingTag ()
{
var parser = new XmlTreeParser (CreateRootState ());
var result = parser.Parse (@"<root / $>",

() => {
parser.AssertStateIs<XmlTagState> ();
});

parser.AssertDiagnostics (
(XmlCoreDiagnostics.MalformedSelfClosingTag, 7, 0)
);
}

[Test]
public void MismatchedElementNameWithNamespace ()
{
Expand Down
7 changes: 6 additions & 1 deletion Core/Parser/XmlTagState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public class XmlTagState : XmlParserState

const int ATTEMPT_RECOVERY = 1;
const int RECOVERY_FOUND_WHITESPACE = 2;
const int MAYBE_SELF_CLOSING = 2;
const int MAYBE_SELF_CLOSING = 3;
const int FREE = 0;

readonly XmlAttributeState AttributeState;
Expand Down Expand Up @@ -139,6 +139,11 @@ public XmlTagState (XmlAttributeState attributeState, XmlNameState nameState)
return null;
}

if (context.StateTag == MAYBE_SELF_CLOSING) {
context.Diagnostics?.Add (XmlCoreDiagnostics.MalformedSelfClosingTag, context.Position, c);
return null;
}

if (context.StateTag == ATTEMPT_RECOVERY) {
if (XmlChar.IsWhitespace (c)) {
context.StateTag = RECOVERY_FOUND_WHITESPACE;
Expand Down