PFB inversion added as a reader class for ARO data#43
Open
ramain wants to merge 3 commits intomhvk:fft-trialsfrom
Open
PFB inversion added as a reader class for ARO data#43ramain wants to merge 3 commits intomhvk:fft-trialsfrom
ramain wants to merge 3 commits intomhvk:fft-trialsfrom
Conversation
scintellometry/io/arochime.py
Outdated
Owner
There was a problem hiding this comment.
This import will mean that effectively pfb becomes a dependency for scintellometry, since one cannot access the AROCHIME readers without importing it. I think instead we should either make it part of scintellometry, or do a local import.
Owner
There was a problem hiding this comment.
Tiny, but use from ..ppf import pfb
Owner
|
@ramain - a number of mostly nitpicky comments, but I think we might as well try to keep it clean(ish). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.