3873 ic time input ic change event detail includes current date#4236
Merged
GCHQ-Developer-530 merged 3 commits intodevelopfrom Feb 16, 2026
Conversation
Contributor
|
View your canary branch deployment here: https://mi6.github.io/ic-ui-kit/branches/3873-ic-time-input---ic-change-event-detail-includes-current-date/canary-web-components |
ad3872
force-pushed
the
3873-ic-time-input---ic-change-event-detail-includes-current-date
branch
from
831429a to
9ad200d
Compare
GCHQ-Developer-299
previously approved these changes
Feb 5, 2026
jd3267
requested changes
Feb 6, 2026
GCHQ-Developer-299
dismissed
their stale review
other reviewers have raised requests
ad3872
force-pushed
the
3873-ic-time-input---ic-change-event-detail-includes-current-date
branch
from
9ad200d to
58d588b
Compare
ad3872
force-pushed
the
3873-ic-time-input---ic-change-event-detail-includes-current-date
branch
from
58d588b to
d00ff92
Compare
ad3872
requested review from
GCHQ-Developer-299,
GCHQ-Developer-530 and
jd3267
docs change to remove the date() object for a string to display the time only
adjusts test thersholds to meet required passing threshold
…o display only the time Removes the date() object for the value in the ic-time-input and uses a string to ensure only the time is displayed
ad3872
force-pushed
the
3873-ic-time-input---ic-change-event-detail-includes-current-date
branch
from
d00ff92 to
6ddebd8
Compare
jd3267
approved these changes
Feb 12, 2026
GCHQ-Developer-530
approved these changes
Feb 16, 2026
GCHQ-Developer-530
deleted the
3873-ic-time-input---ic-change-event-detail-includes-current-date
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Refactored ic-time-input to remove the Date object so now it only shows the time as a string.
Related issue
#3873
Checklist
General
Testing
System modes