Skip to content

4238 lang attribute input label#4261

Merged
GCHQ-Developer-299 merged 5 commits intodevelopfrom
4238-lang-attribute-input-label
Feb 24, 2026
Merged

4238 lang attribute input label#4261
GCHQ-Developer-299 merged 5 commits intodevelopfrom
4238-lang-attribute-input-label

Conversation

@jd3267
Copy link
Copy Markdown
Contributor

@jd3267 jd3267 commented Feb 11, 2026 •
edited
Loading

Summary of the changes

Added label slot to ic-input-label to allow for addition of lang attributes to text

Related issue

#4238

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 11, 2026

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/4238-lang-attribute-input-label/web-components
View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/4238-lang-attribute-input-label/react

@jd3267 jd3267 force-pushed the 4238-lang-attribute-input-label branch from a501385 to 3518e86 Compare February 11, 2026 14:08
@jd3267 jd3267 marked this pull request as ready for review February 11, 2026 14:09
@lz405
Copy link
Copy Markdown
Contributor

lz405 commented Feb 11, 2026

Could use a storybook example of using the new slot.

@GCHQ-Developer-530
Copy link
Copy Markdown
Contributor

GCHQ-Developer-530 commented Feb 12, 2026

Could use a storybook example of using the new slot.

And a Cypress visual regression test too please

@jd3267 jd3267 marked this pull request as draft February 12, 2026 09:53
@jd3267 jd3267 force-pushed the 4238-lang-attribute-input-label branch 11 times, most recently from 24487fc to 0b2747e Compare February 19, 2026 12:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

Cypress visual tests failed.
View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/4238-lang-attribute-input-label/cypress-image-diff-screenshots/diff
View the html report here: https://mi6.github.io/ic-ui-kit/branches/4238-lang-attribute-input-label/cypress-image-diff-html-report/cypress-image-diff-html-report.html

@jd3267 jd3267 force-pushed the 4238-lang-attribute-input-label branch from 0b2747e to dcf0152 Compare February 19, 2026 13:07
@jd3267
docs(docs): update to docs for adding of label slot to ic-input-label
520e430 
update to docs for adding of label slot to ic-input-label
@jd3267
docs(canary-docs): update to docs for adding of label slot to ic-inpu…
6375fe1 
…t-label

update to docs for adding of label slot to ic-input-label
@jd3267 jd3267 force-pushed the 4238-lang-attribute-input-label branch from dcf0152 to 1921692 Compare February 19, 2026 13:44
@jd3267 jd3267 marked this pull request as ready for review February 19, 2026 14:18
@jd3267 jd3267 force-pushed the 4238-lang-attribute-input-label branch 2 times, most recently from 789ad5d to b9d6bfc Compare February 19, 2026 14:23
GCHQ-Developer-530
GCHQ-Developer-530 reviewed Feb 20, 2026
View reviewed changes
Comment thread packages/react/src/component-tests/IcCheckbox/IcCheckbox.cy.tsx Outdated
@jd3267 jd3267 force-pushed the 4238-lang-attribute-input-label branch from b9d6bfc to 866f302 Compare February 20, 2026 11:31
GCHQ-Developer-530
GCHQ-Developer-530 reviewed Feb 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@GCHQ-Developer-530 GCHQ-Developer-530 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just one more comment, could you change the short commit message for the web components commit to say which components you've added the label slot for? That way when the automation happens to put it on the roadmap, it has more context

@jd3267
feat(web-components): addition of label slot to ic-input-label and ic…
bb3339f 
…-checkbox-group

addition of label slot to ic-input-label to and ic-checkbox-group to allow adding lang attributes to text
@jd3267
feat(react): adds story example to checkbox-group
77762d8 
adds story example to checkbox-group to test slotted label with changes to input-label
@jd3267
chore(root): add french words to cspell
cf99682 
add french words to cspell for lang tag tests
@jd3267 jd3267 force-pushed the 4238-lang-attribute-input-label branch from 866f302 to cf99682 Compare February 20, 2026 16:03
@GCHQ-Developer-299 GCHQ-Developer-299 merged commit 7fe8bd4 into develop Feb 24, 2026
6 checks passed
@jd3267 jd3267 mentioned this pull request Feb 24, 2026
Open
@jd3267 jd3267 deleted the 4238-lang-attribute-input-label branch February 26, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GCHQ-Developer-299 GCHQ-Developer-299 GCHQ-Developer-299 approved these changes

@GCHQ-Developer-530 GCHQ-Developer-530 GCHQ-Developer-530 approved these changes

@lz405 lz405 Awaiting requested review from lz405

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jd3267 @lz405 @GCHQ-Developer-530 @GCHQ-Developer-299