feat: add sztaki specific block_device support for OpenStack VMs#279
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces Sztaki-specific block_device support for OpenStack VMs by augmenting the Terraform template generation.
- Added extraction of auth_url (and tenant_id) to detect Sztaki endpoints.
- Conditionally adds block_device configuration for Sztaki VMs in the get_virtual_machine function.
- Removed duplicate extraction of auth_url and tenant_id later in the file.
| auth_url = ( | ||
| properties.get("auth_url") | ||
| or properties.get("endpoint") | ||
| or properties.get("endpoint_cloud") |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| or properties.get("endpoint_cloud") | ||
| ) | ||
| is_sztaki = "sztaki" in auth_url.lower() | ||
| tenant_id = properties.get("project_id") |
There was a problem hiding this comment.
[nitpick] The variable tenant_id is set but not used within the shown diff. If it is not required, consider removing it to reduce unused code clutter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check that the PR fulfills these requirements
What type of PR is this? (Bug fix, feature, docs update, ...)
What does the PR do / why is it needed?
Which issue(s) does this PR fix:
Fixes #
Does this PR introduce a user-facing change?
Other information: