Skip to content

Silence web piano if input is coming from MIDI - #8

Open
nbelakovski wants to merge 1 commit into
michaelnew:masterfrom
nbelakovski:silence_piano_upon_midi_input
Open

Silence web piano if input is coming from MIDI#8
nbelakovski wants to merge 1 commit into
michaelnew:masterfrom
nbelakovski:silence_piano_upon_midi_input

Conversation

@nbelakovski

Copy link
Copy Markdown
Contributor

I found it really annoying that when I used my MIDI keyboard, I'd have to turn it's sound off and use the sound from the computer (or just have both on, but that felt weird).

I thought about making this into an option, but it seemed like there wasn't much of a use case for turning off the web piano when you don't have a midi keyboard, and also not much of a use case for leaving it on if you do have a midi keyboard.

What do you think?

@ghost

ghost commented Feb 11, 2018

Copy link
Copy Markdown

@nbelakovski I have a KeyStation 88 MIDI controller. It provides MIDI input, but it does not have speakers or produce sound on its own.
So, there is a very real use-case for keeping the audio on the application. At least make it a user preference.

@nbelakovski

Copy link
Copy Markdown
Contributor Author

OK will do. I'll probably make a mute icon next to the keyboard, and probably get rid of the mute dialog near the top. The downside to that approach is a need to do two things to mute the thing, but the alternative is to have 3 buttons that can mute different things. I'm open to implementation suggestions.

Just curious, @errorx666, what do you normally hook that keyboard up to?

@ghost

ghost commented Feb 12, 2018

Copy link
Copy Markdown

I bought it to use with Propellerhead Reason. I wanted an input with semi weighted keys and a full range of keys. It cost a tenth of what a comparable electric piano would have, and it came bundled with a very nice piano synthesizer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant