Skip to content

fix: cache the SDK dist/ output in turbo - #8

Open
pyjeebz wants to merge 1 commit into
michaelshimeles:mainfrom
pyjeebz:fix/turbo-sdk-outputs
Open

fix: cache the SDK dist/ output in turbo#8
pyjeebz wants to merge 1 commit into
michaelshimeles:mainfrom
pyjeebz:fix/turbo-sdk-outputs

Conversation

@pyjeebz

@pyjeebz pyjeebz commented Jul 19, 2026

Copy link
Copy Markdown

Every npm run build / npm run check currently prints:

WARNING  no output files found for task boring-computers-sdk#build. Please check your `outputs` key in turbo.json

The SDK compiles into dist/, but the shared build task's outputs only lists .svelte-kit/**, build/**, and .vercel/**, so turbo never captures (or caches) the SDK build.

This adds dist/** to the list. Verified locally: the warning is gone, and a repeat turbo build --filter=boring-computers-sdk goes from ~16s to a full cache hit (~70ms).

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings July 19, 2026 00:53
@vercel

vercel Bot commented Jul 19, 2026

Copy link
Copy Markdown

@pyjeebz is attempting to deploy a commit to the Goshen Labs Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Turborepo build task configuration so Turbo recognizes and caches the SDK’s dist/ build artifacts, eliminating the “no output files found” warning and enabling cache hits for subsequent SDK builds.

Changes:

  • Add dist/** to the build task outputs in turbo.json so Turbo captures SDK build output for caching.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@greptile-apps

greptile-apps Bot commented Jul 19, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates Turbo's shared build cache outputs for the SDK package. The main change is:

  • Adds dist/** to the build task outputs so SDK dist/ artifacts can be cached.

Confidence Score: 5/5

Safe to merge with minimal risk.

The change is a single Turbo configuration update that matches the described SDK build output and does not alter runtime behavior.

No files require special attention.

T-Rex T-Rex Logs

What T-Rex did

  • The first run of the SDK turbo cache validation completed with a cache miss and finished successfully.
  • The second run completed with a cache hit and replayed logs, showing 1 cached and 1 total, with the FULL TURBO indicator and exit code 0.
  • A summary artifact confirms dist_exists=true, warnings are false in both logs, and second_run_cache_hit_evidence=true.
  • The run script and both before/after log artifacts were reviewed to verify the two-run sequence and the summary indicators.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
turbo.json Adds dist/** to the shared Turbo build outputs so SDK build artifacts are captured by the cache.

Reviews (1): Last reviewed commit: "fix: cache the SDK dist/ output in turbo" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants