feat: add PlaneWaveFocuserDeviceInterfaceStatus to status in pwi module#60
Open
michealroberts wants to merge 1 commit intomainfrom
Open
feat: add PlaneWaveFocuserDeviceInterfaceStatus to status in pwi module#60michealroberts wants to merge 1 commit intomainfrom
michealroberts wants to merge 1 commit intomainfrom
Conversation
feat: add PlaneWaveFocuserDeviceInterfaceStatus to status in pwi module
There was a problem hiding this comment.
Pull Request Overview
This pull request adds a new device status class for the focuser, along with corresponding tests, and updates the package interface.
- Introduces PlaneWaveFocuserDeviceInterfaceStatus in src/pwi/status.py with parsing and validator logic
- Adds unit tests for focuser status parsing in test/test_status.py
- Exposes the new focuser interface status in src/pwi/init.py
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test_status.py | Adds tests for focuser status parsing and missing key behavior |
| src/pwi/status.py | Implements the new focuser interface status with validation logic |
| src/pwi/init.py | Updates public API to include the new focuser status class |
Comment on lines
+247
to
+248
| return value.lower() == "true" | ||
|
|
There was a problem hiding this comment.
Consider trimming the string (e.g., using value.strip()) before converting to lowercase, to ensure robust boolean parsing when extra whitespace is present.
Suggested change
| return value.lower() == "true" | |
| return value.strip().lower() == "true" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add PlaneWaveFocuserDeviceInterfaceStatus to status in pwi module