Added support for ESP32 with Husarnet TCPv6 transport#708
Added support for ESP32 with Husarnet TCPv6 transport#708DominikN wants to merge 6 commits intomicro-ROS:galacticfrom
Conversation
|
Hello @DominikN, thanks a lot for the contribution. Can you detail the reasons why the old ESP toolchain is needed? @Acuadros95 in general this LGTM, what about all the style change at |
|
@mergify backport main foxy |
🟠 Waiting for conditions to matchDetails
|
src/husarnet_transport.cpp
Outdated
|
|
||
| /* Try to connect to a server on port 8888 on your laptop */ | ||
| if (!client.connect(locator->hostname, locator->port)) { | ||
| Serial1.printf("failed\r\n"); |
| find firmware/build/include/ -name "*.c" -delete | ||
| cp -R firmware/build/include/* /project/src/ | ||
|
|
||
| mkdir -p /project/src/esp32_5_2_0 |
There was a problem hiding this comment.
Will Arduino IDE look in this path for the library?
There was a problem hiding this comment.
Only with additional flags:
-L <path_to_microros>/src/esp32_5_2_0/
-l microros
There is still esp32 folder that will be handled by default by Arduino IDE
|
In general I agree with @pablogs9:
|
|
Hi guys, in the micro-ROS/docker#76 - I added a toolchain for building microros static library based on the same toolchain version as used for a current version of Husarnet for ESP32. We are in the process of making Husarnet working as a standard Arduino library working with the latest releases of https://github.com/espressif/arduino-esp32 . Right now Husarnet uses this fork: https://github.com/husarnet/arduino-esp32. Main issue behind using a custom fork was a poor support of IPv6 in the past, but it has changed (also due our PRs) and in the following months we will get rid of our fork. By this time I will also make a PR to get rid of I would like to present Husarnet, micro-ROS and ESP32 during my presentation at ROS 2 Embedded Working Group working with micro-ROS based on the https://github.com/micro-ROS/micro_ros_arduino and not on my fork. |
|
Co-authored-by: Pablo Garrido <pablogs9@gmail.com>
|
Hi @DominikN, we have been discussing this internally and the best option is to wait until we can have this built with the mainline compiler version. As soon as this transport is compatible with the version of the ESP32 compiler we will merge this. Regarding the EWG, do not worry about using local branches, we can say that all the shown features will be available as soon as the compiler issue is solved. |
|
Sure, that's fine. Thanks for your reply. |
No description provided.