Skip to content

fix frame_clone_and_push_hdr: guard stack overflow at the push site #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeso-mchp wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix frame_clone_and_push_hdr: guard stack overflow at the push site #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/ef-args.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,6 @@ int argc_frame(int argc, const char *argv[], frame_t *f) {
int i, j, res, offset;
hdr_t *h;

if(argc > FRAME_STACK_MAX) {
po("ERROR: Frame stack size is too big");
return -1;
}

offset = 0;
frame_reset(f);

Expand Down
8 changes: 3 additions & 5 deletions src/ef.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,12 +314,10 @@ void frame_reset(frame_t *f) {
}

hdr_t *frame_clone_and_push_hdr(frame_t *f, hdr_t *h) {
hdr_t *new_hdr = hdr_clone(h);
if (f->stack_size >= FRAME_STACK_MAX)
return NULL;

f->stack[f->stack_size] = new_hdr;
f->stack_size ++;

return new_hdr;
return f->stack[f->stack_size++] = hdr_clone(h);
}

int hdr_parse_fields(frame_t *frame, struct hdr *hdr, int offset,
Expand Down