Draft
Conversation
Author
|
The changes in #3351 didn't work for me, in particular the connection attempts in CastMediaRouteController throw errors. I don't think changes are needed to that class anyway (at least not to get basic casting working) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #580
This fixes a few issues preventing casting from working properly. My main focus has been to get casting from the youtube app working. I've tested this on a CCwGTV from an emulator (with a hardcoded address since emulator can't do mDNS) and it seems to be able to start a session and control media playback. The disconnect process is a bit broken so still need to dig into that.