More tests for @LRA defined at the class level are needed#360
Open
marcosgopen wants to merge 1 commit into
Open
More tests for @LRA defined at the class level are needed#360marcosgopen wants to merge 1 commit into
marcosgopen wants to merge 1 commit into
Conversation
Contributor
|
retest this please [edit] this probably won't work but worth a try anyway. |
mmusgrov
approved these changes
Jun 20, 2022
Contributor
mmusgrov
left a comment
mmusgrov
left a comment
There was a problem hiding this comment.
Thanks for adding these missing tests @marcosgopen
I am approving the PR but let's wait for a second review before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves issue #359