Skip to content

Conversation

@ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jan 27, 2026

Closes #139

  • Revert commit 082e76a
  • Replace greenboot service restarts by microshift healthcheck command

Note: This PR can be merged as soon as the fedora-iot/greenboot-rs#132 fix is released in Fedora 43 and CentOS 9 / 10 upstream.

Summary by CodeRabbit

  • Chores

    • Removed strict version pinning for the greenboot package to allow more flexible updates.
  • Bug Fixes / Maintenance

    • Replaced direct host service restart with an in-container healthcheck invocation for improved startup validation.
    • Simplified startup sequence to enable and restart the primary service only, removing an extra healthcheck service restart.

✏️ Tip: You can customize this high-level summary in your review settings.

@ggiguash ggiguash requested a review from a team as a code owner January 27, 2026 14:29
@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

Removed explicit greenboot-0.15.* installation/pinning from packaging and RPM install paths; replaced direct greenboot-healthcheck.service restarts in CI with a podman-run microshift healthcheck call; simplified service handling in an isolated-network script to only enable and restart microshift.

Changes

Cohort / File(s) Summary
Greenboot pin removal
packaging/bootc.Containerfile, src/quickrpm.sh
Removed inline greenboot-0.15.* installation/pinning and related dnf install steps.
CI healthcheck substitution
.github/actions/quick-rpm-clean/action.yaml
Replaced greenboot-healthcheck.service restart calls with sudo podman exec -i microshift-okd microshift healthcheck -v=2 --timeout=600s and updated comments.
Service restart simplification
src/config_isolated_net.sh
Replaced loop restarting microshift and greenboot-healthcheck with enabling and restarting only the microshift service.

Sequence Diagram(s)

mermaid
sequenceDiagram
participant Action as GitHub Action (quick-rpm-clean)
participant Host as Runner Host
participant Podman as Podman
participant Container as microshift-okd container
participant Healthcheck as microshift healthcheck
rect rgba(60,120,200,0.5)
Action->>Host: run workflow step
Host->>Podman: podman exec -i microshift-okd microshift healthcheck -v=2 --timeout=600s
Podman->>Container: invoke microshift binary
Container->>Healthcheck: execute health checks
Healthcheck-->>Action: return status/result
end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • agullon
  • copejon
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the primary change: replacing greenboot service restarts with microshift healthcheck procedure across multiple files.
Linked Issues check ✅ Passed Changes address issue #139 by removing greenboot service restarts and replacing them with microshift healthcheck commands, which avoids triggering the greenboot mount-info failure.
Out of Scope Changes check ✅ Passed All changes directly relate to the stated objective: removing greenboot package pins and replacing greenboot service restarts with microshift healthcheck.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ggiguash ggiguash changed the title Revert "Pin greenboot 0.15.z version in bootc and quick-rpm" Use microshift healthcheck procedure instead of restarting greenboot service Jan 27, 2026
@ggiguash
Copy link
Contributor Author

@coderabbitai
Perform full review.

@coderabbitai
Copy link

coderabbitai bot commented Jan 27, 2026

@ggiguash I'll perform a full review of the PR.

✅ Actions performed

Full review triggered.

@ggiguash ggiguash marked this pull request as draft January 27, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Greenboot fails with "failed to read mount info" on Fedora 43

1 participant