Moving hosting-dialogs tests back into tests/ directory#379
Merged
rodrigobr-msft merged 1 commit intomainfrom Apr 29, 2026
Merged
Moving hosting-dialogs tests back into tests/ directory#379rodrigobr-msft merged 1 commit intomainfrom
rodrigobr-msft merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relocates/rehydrates the hosting-dialogs test suite under the repo’s primary tests/ tree, adding a DialogTestAdapter compatibility layer plus a broad set of unit tests covering dialogs, prompts, choices, and memory scopes.
Changes:
- Added a
tests.hosting_dialogshelper adapter/flow API to support botbuilder-style dialog test patterns. - Added/ported unit tests for dialogs (Dialog/ComponentDialog/DialogContext/DialogManager/DialogSet), prompt types (OAuth/Choice/Confirm/Text/Number/DateTime/Activity/Attachment), waterfalls, and memory scopes/resolvers.
- Added choices subpackage tests (tokenizer/recognizers/factory/channel).
Reviewed changes
Copilot reviewed 31 out of 35 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/hosting_dialogs/init.py | Marks hosting-dialogs tests as a package. |
| tests/hosting_dialogs/helpers.py | Adds DialogTestAdapter/TestFlow wrapper used by many dialog/prompt tests. |
| tests/hosting_dialogs/test_activity_prompt.py | Unit tests for ActivityPrompt validation/retry/error paths. |
| tests/hosting_dialogs/test_attachment_prompt.py | Unit tests for AttachmentPrompt basic/retry/validator behavior. |
| tests/hosting_dialogs/test_choice_prompt.py | Unit tests for ChoicePrompt rendering/recognition/locale behavior. |
| tests/hosting_dialogs/test_component_dialog.py | Unit tests for ComponentDialog composition and dialog calling patterns. |
| tests/hosting_dialogs/test_confirm_prompt.py | Unit tests for ConfirmPrompt rendering/locale/custom culture behavior. |
| tests/hosting_dialogs/test_date_time_prompt.py | Unit tests for DateTimePrompt basic + retry behavior. |
| tests/hosting_dialogs/test_dialog.py | Unit tests for base Dialog behaviors and defaults. |
| tests/hosting_dialogs/test_dialog_context.py | Unit tests for DialogContext APIs (begin/prompt/reprompt/emit_event/etc.). |
| tests/hosting_dialogs/test_dialog_extensions.py | Unit tests for DialogExtensions.run_dialog and reprompt handling. |
| tests/hosting_dialogs/test_dialog_manager.py | Unit tests for DialogManager root-bot flow and tracing behavior. |
| tests/hosting_dialogs/test_dialog_set.py | Unit tests for DialogSet validation, telemetry propagation, versioning. |
| tests/hosting_dialogs/test_number_prompt.py | Unit tests for NumberPrompt recognition, locale, retry, validator behavior. |
| tests/hosting_dialogs/test_oauth_prompt.py | Unit tests for OAuthPrompt behaviors including timeout and credential aliasing. |
| tests/hosting_dialogs/test_object_path.py | Unit tests for ObjectPath assign/get/set/remove behavior. |
| tests/hosting_dialogs/test_prompt_culture_models.py | Unit tests for PromptCultureModels mapping/supported cultures. |
| tests/hosting_dialogs/test_prompt_validator_context.py | Unit tests for PromptValidatorContext attempt_count behavior. |
| tests/hosting_dialogs/test_replace_dialog.py | Unit tests for replace_dialog branching across component dialogs. |
| tests/hosting_dialogs/test_text_prompt.py | Unit tests for TextPrompt basic/validator/retry/non-message behavior. |
| tests/hosting_dialogs/test_waterfall.py | Unit tests for WaterfallDialog sequencing, nesting, prompts, parent semantics. |
| tests/hosting_dialogs/test_waterfall_dialog.py | Unit tests for WaterfallDialog validation/step naming/edge behaviors. |
| tests/hosting_dialogs/test_waterfall_step_context.py | Unit tests for WaterfallStepContext next()/properties behavior. |
| tests/hosting_dialogs/memory/init.py | Marks memory tests as a package. |
| tests/hosting_dialogs/memory/test_at_path_resolver.py | Unit tests for AtPathResolver path transformation. |
| tests/hosting_dialogs/memory/scopes/init.py | Marks memory scopes tests as a package. |
| tests/hosting_dialogs/memory/scopes/test_memory_scopes.py | Unit tests for multiple memory scopes (class/user/convo/dialog/turn/etc.). |
| tests/hosting_dialogs/memory/scopes/test_settings.py | Provides DefaultConfig used by SettingsMemoryScope tests. |
| tests/hosting_dialogs/choices/init.py | Marks choices tests as a package. |
| tests/hosting_dialogs/choices/test_channel.py | Unit tests for Channel helper behavior/capabilities. |
| tests/hosting_dialogs/choices/test_choice.py | Unit tests for Choice model round-trips. |
| tests/hosting_dialogs/choices/test_choice_factory.py | Unit tests for ChoiceFactory rendering (inline/list/actions/cards). |
| tests/hosting_dialogs/choices/test_choice_factory_options.py | Unit tests for ChoiceFactoryOptions fields. |
| tests/hosting_dialogs/choices/test_choice_recognizers.py | Unit tests for Find/ChoiceRecognizers behavior. |
| tests/hosting_dialogs/choices/test_choice_tokenizer.py | Unit tests for Tokenizer behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
axelsrz
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests had to be moved out/disabled, otherwise our Azure DevOps pipeline would fail.