This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Use dispatch proxy#2
Open
maciejw wants to merge 3 commits into
Open
Conversation
|
|
Author
|
BTW this |
|
@maciejw, this PR looks really good. Would love it, if it got merged. Any chance that you might try again at signing the agreement? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, what do you think about moving from castle dynamic proxy to built in DispatchProxy class, have you considered it when you started this project?
I did few minor upgrades also, like migrate test project to sdk proj, or converted test to xunit since this is default choice in aspnetcore projects.
I also bumped version to 2.0.0 since DispatchProxy requires net461.
I've used typed factories in castle and I think its cool idea, it would be cool to add to https://github.com/aspnet/Extensions