Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

Use dispatch proxy#2

Open
maciejw wants to merge 3 commits into
microsoft:masterfrom
maciejw:use-dispatch-proxy
Open

Use dispatch proxy#2
maciejw wants to merge 3 commits into
microsoft:masterfrom
maciejw:use-dispatch-proxy

Conversation

@maciejw

@maciejw maciejw commented Sep 3, 2019

Copy link
Copy Markdown

Hello, what do you think about moving from castle dynamic proxy to built in DispatchProxy class, have you considered it when you started this project?
I did few minor upgrades also, like migrate test project to sdk proj, or converted test to xunit since this is default choice in aspnetcore projects.
I also bumped version to 2.0.0 since DispatchProxy requires net461.

I've used typed factories in castle and I think its cool idea, it would be cool to add to https://github.com/aspnet/Extensions

@msftclas

msftclas commented Sep 3, 2019

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ maciejw sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@maciejw maciejw marked this pull request as ready for review September 3, 2019 00:35
@maciejw

maciejw commented Sep 3, 2019

Copy link
Copy Markdown
Author

BTW this license/cla Pending — Contributor License Agreement is not signed yet. does not work properly, I've signed it.

@DaveRMaltby

Copy link
Copy Markdown

@maciejw, this PR looks really good. Would love it, if it got merged. Any chance that you might try again at signing the agreement?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants