-
Notifications
You must be signed in to change notification settings - Fork 175
fix all markdown lint errors in docs #4833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add a small section on MFA
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit f8ea0df. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes markdown lint errors across documentation files by addressing table formatting issues, improving link text descriptions, and correcting spacing inconsistencies. The changes were verified using make lint-docs which now shows all markdown and YAML files lint successfully.
Changes:
- Fixed markdown table formatting by ensuring proper alignment of table separator rows with column headers
- Improved link text from generic phrases like "here" to descriptive text that indicates the link destination
- Added missing blank lines before and after tables and headings to comply with markdown formatting standards
Reviewed changes
Copilot reviewed 21 out of 27 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/workspace_services/guacamole/user_resources/README.md | Fixed table formatting alignment for image properties documentation |
| docs/using-tre/templates/index.md | Replaced generic "here" links with descriptive link text |
| docs/tre-workspace-authors/firewall-rules.md | Fixed table separator formatting for multiple tables throughout the document |
| docs/tre-templates/workspaces/base.md | Added missing table cell content for client_secret description |
| docs/tre-templates/workspace-services/ohdsi.md | Improved link text from "here" to descriptive text |
| docs/tre-templates/user-resources/guacamole-linux-vm.md | Improved link text from "here" to descriptive reference |
| docs/tre-templates/shared-services/nexus.md | Removed trailing whitespace from table cell |
| docs/tre-templates/shared-services/gitea.md | Removed trailing whitespace and fixed URL formatting |
| docs/tre-developers/end-to-end-tests.md | Improved link text to be more descriptive |
| docs/tre-developers/api-permissions-map.md | Added blank lines before tables and fixed table alignment |
| docs/tre-admins/setup-instructions/deployment-repo.md | Improved link text with descriptive reference |
| docs/tre-admins/setup-instructions/configuring-shared-services.md | Replaced generic "here" links with descriptive text |
| docs/tre-admins/identities/workspace.md | Fixed table formatting and added blank lines before tables |
| docs/tre-admins/identities/test-account.md | Fixed table formatting and added blank lines before tables |
| docs/tre-admins/identities/client.md | Fixed table formatting and added blank lines before tables |
| docs/tre-admins/identities/auth-manual.md | Fixed table formatting and added blank line before table |
| docs/tre-admins/identities/application_admin.md | Fixed table separator formatting |
| docs/tre-admins/identities/api.md | Fixed table formatting and added blank lines before tables |
| docs/tre-admins/auth.md | Improved link text and fixed table formatting |
| docs/azure-tre-overview/user-roles.md | Fixed table separator formatting and improved link text |
| docs/azure-tre-overview/tre-resources-breakdown.md | Fixed table separator formatting across multiple resource tables |
| docs/azure-tre-overview/networking.md | Fixed table separator formatting |
| docs/azure-tre-overview/cost-reporting.md | Fixed table formatting and spacing |
| docs/azure-tre-overview/case-studies.md | Improved link text from "Click here" to descriptive references |
| docs/azure-tre-overview/architecture.md | Removed trailing whitespace from table cell |
| docs/azure-tre-overview/airlock.md | Fixed table formatting and improved link text |
| README.md | Added alt text attribute to Azure TRE logo image |
templates/workspace_services/guacamole/user_resources/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 23 out of 29 changed files in this pull request and generated 1 comment.
templates/workspace_services/guacamole/user_resources/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
marrobi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
|
/test-force-approve 4c0cf02 docs only |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 4c0cf02) (in response to this comment from @marrobi) |
|
/test-force-approve docs |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit f8ea0df) (in response to this comment from @marrobi) |
What is being addressed
fixes all markdown lint errors in docs
How is this addressed
make lint-docsto check for errors and resolved all issues