This repository was archived by the owner on Dec 11, 2020. It is now read-only.
Modifying documentation to work for VS 2017#6
Open
katelmaroney wants to merge 2 commits intomicrosoft:v15.0from
Open
Modifying documentation to work for VS 2017#6katelmaroney wants to merge 2 commits intomicrosoft:v15.0from
katelmaroney wants to merge 2 commits intomicrosoft:v15.0from
Conversation
AArnott
suggested changes
Oct 12, 2017
Member
AArnott
left a comment
AArnott
left a comment
There was a problem hiding this comment.
Thanks for this. It looks much better.
| { | ||
| [ConnectedServiceHandlerExport("Contoso.SampleService", | ||
| AppliesTo = "CSharp+Web")] | ||
| AppliesTo = "CSharp | Web")] |
Member
There was a problem hiding this comment.
This seems like an odd AppliesTo expression, to work with any Web project and also work with any C# project. So you work with console apps, class libraries, etc. and also VB web projects.
I think the and operator used before made more sense. Why the change?
| You will implement the changes to the app developer's project in the AddServiceInstanceAsync method. We'll show you to do in a later section. For now, we simply return a simple instance of the AddServiceInstanceResult. | ||
|
|
||
| F5 again, create a C# Web project, open the Connected Service dialog, and you will see the sample provider can now be configured. | ||
| F5 again, create a C# Console App project, open the Connected Service dialog, and you will see the sample provider listed in the Connected Services tab |
Member
There was a problem hiding this comment.
This may need revisiting based on the outcome of the AppliesTo expression comment I left earlier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.