Document and improve the usage of wsl/winadapter.h and wsl/wrladapter.h#113
Open
lygstate wants to merge 5 commits intomicrosoft:mainfrom
Open
Document and improve the usage of wsl/winadapter.h and wsl/wrladapter.h#113lygstate wants to merge 5 commits intomicrosoft:mainfrom
wsl/winadapter.h and wsl/wrladapter.h#113lygstate wants to merge 5 commits intomicrosoft:mainfrom
Conversation
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
…fine old versions is The correct way to deal with this is #include <wsl/winadapter.h> before any other windows sdk or direct-x headers
Member
|
A lot of this PR appears to be whitespace trimming. I can't really see the change here that's being proposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To make sure the souce to be compatiable for both Win32(MSVC/MINGW)/Linux,
wsl/winadapter.handwsl/wrladapter.hshould be included at the begnning of the souce file.