driver hang workaround, remove midi2 feature staging#951
Merged
Psychlist1972 merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
Psychlist1972
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some 3rd party drivers are failing to cancel the pended irp when shutting down midi in. In the legacy code path, this exhibits as the application process & thread staying zombied in the system until reboot. For midisrv, the blocked driver shutdown causes a service deadlock and application hangs.
It was found that for these drivers transitioning the pin from run->pause before shutting down the worker thread will complete the pended irps without relying on irp cancellation, working around the driver failing to handle irp cancellation.